creation of car from file / directory #246
Conversation
|
I pushed an initial test script to make reproing easier. |
Makes sense. I'm building the unixfsnode builders for files and then directories at the same time, which is why these look a bit piecemeal. |
|
@willscott from what I can see, this is doing a leaves-first build of the DAG, right? There's no fancy buffering or anything else going on to order it according to a top-down DAG walk. Which I think gives it parity with ipfs-car (JS) but isn't the "deterministic" ordering you'd get from |
|
correct. this is write order, and does not follow any specific selector order. |
cmd/car/car.go
Outdated
| Name: "file", | ||
| Aliases: []string{"f"}, |
There was a problem hiding this comment.
-o --output would be mildly more famililar here and consistent with ipfs-car
There was a problem hiding this comment.
i was trying to follow the flags from tar, i'll add both as equivalent aliases.
There was a problem hiding this comment.
oh, this is for creating a car not extracting. Ignore me. As you were.
There was a problem hiding this comment.
tho, on second thoughts it does still feel more like an --output kind of a deal here. ipfs-car is using --output for "where to write the car to" when creating and "where to unpack the files to" when extracting.
There was a problem hiding this comment.
Déjà vu! Oli and I had identical argument regarding ipfs-car, I said be like tar, Oli says tar is terrible, don't copy it.
There was a problem hiding this comment.
uh huh. "if you know how tar works then you know how car works" sounds compelling, and given our erudite nieche may be the right choice for the immediate audience.
My experience has been that tar is used as an example of a command that folks stuggle to remember what the flags do, so I aimed elsewhere. But we can have both. ipfs-car is not car and won't try to be, and folks can use the flavour that works for them.
|
@rvagg when i go to |
|
If i don't hear objections to the current state of this PR in the next day i'm going to move forward merging it, and use smaller follow-up PRs to improve on remaining rough edges |
|
No objections! |
|
diff hidden```diff diff --git a/cmd/car/get.go b/cmd/car/get.go index 0343154..8f81b1e 100644 --- a/cmd/car/get.go +++ b/cmd/car/get.go @@ -87,7 +87,7 @@ func GetCarDag(c *cli.Context) error { ls := cidlink.DefaultLinkSystem() ls.TrustedStorage = true ls.StorageReadOpener = func(_ linking.LinkContext, l datamodel.Link) (io.Reader, error) { - if cl, ok := l.(*cidlink.Link); ok { + if cl, ok := l.(cidlink.Link); ok { blk, err := bs.Get(cl.Cid) if err != nil { if err == ipfsbs.ErrNotFound { @@ -105,7 +105,7 @@ func GetCarDag(c *cli.Context) error { ls.StorageWriteOpener = func(_ linking.LinkContext) (io.Writer, linking.BlockWriteCommitter, error) { buf := bytes.NewBuffer(nil) return buf, func(l datamodel.Link) error { - if cl, ok := l.(*cidlink.Link); ok { + if cl, ok := l.(cidlink.Link); ok { blk, err := blocks.NewBlockWithCid(buf.Bytes(), cl.Cid) if err != nil { return err ``` |
|
never mind, I pushed that change, I was in the code anyway |
* creation of car from file / directory Co-authored-by: Daniel Martí <mvdan@mvdan.cc> Co-authored-by: Rod Vagg <rod@vagg.org>
car create -f out.car [file|dir]...car list --unixfs unixfs.carcar list -v any.carcar index --v1 any.carv2Depends on ipfs/go-unixfsnode#12